DamianPendrak commented on code in PR #32959:
URL: https://github.com/apache/superset/pull/32959#discussion_r2026652601
##########
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx:
##########
@@ -276,20 +231,16 @@ const SqlEditorLeftBar = ({
height: ${tableMetaDataHeight}px;
`}
>
- <Collapse
- activeKey={tables
- .filter(({ expanded }) => expanded)
- .map(({ id }) => id)}
- css={collapseStyles}
- expandIconPosition="right"
- ghost
- onChange={onToggleTable}
- expandIcon={renderExpandIconWithTooltip}
- >
- {tables.map(table => (
- <TableElement table={table} key={table.id} />
- ))}
- </Collapse>
+ {tables.map(table => (
+ <TableElement
+ table={table}
+ key={table.id}
+ activeKey={tables
+ .filter(({ expanded }) => expanded)
+ .map(({ id }) => id)}
+ onChange={onToggleTable}
+ />
+ ))}
Review Comment:
Mainly because of the hover functionality for the tooltip and the fact that
the Collapse items prop accepts label and children as separate components
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
