GitHub user kasiazjc added a comment to the discussion: Inconsistent spacing 
between viz gallery charts

> ## Description
> Depending on the chart's name length, we have inconsistent spacing between 
> viz gallery charts.
> 
> ## Screenshot
> <img alt="Screenshot 2024-05-31 at 10 36 49" width="1785" 
> src="https://private-user-images.githubusercontent.com/70410625/335603498-b0064e56-be55-4693-bc9b-dc150382a4b9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIyNTM1MDIsIm5iZiI6MTcyMjI1MzIwMiwicGF0aCI6Ii83MDQxMDYyNS8zMzU2MDM0OTgtYjAwNjRlNTYtYmU1NS00NjkzLWJjOWItZGMxNTAzODJhNGI5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI5VDExNDAwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI2NGQxMmFkYTdjNjc2NmIzZGJhMmIxMjFiNWE0MThlZmQ3OWVhZDJjMGFjYmRkOGQyY2MzYmY2NGZhYjc5ZGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.23o7T3KXycOyWL1xK9U7TsyZDKsWoZFMqlfD31iNwG4";>
>  <img alt="Screenshot 2024-05-31 at 10 37 08" width="1784" 
> src="https://private-user-images.githubusercontent.com
 
/70410625/335603516-5b78081e-5721-4cb3-a91c-f79d4f1e414a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIyNTM1MDIsIm5iZiI6MTcyMjI1MzIwMiwicGF0aCI6Ii83MDQxMDYyNS8zMzU2MDM1MTYtNWI3ODA4MWUtNTcyMS00Y2IzLWE5MWMtZjc5ZDRmMWU0MTRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI5VDExNDAwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcyN2I1ZmNiZTllZGY0M2EyODQ0MjkxZjk0NWVkNDVmNjYyYjc0YzZmMjI1ZjI2OTFiZGVjMWVhZTVlNTU5NWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YAveJvvru1nvZvfkEyGaJNIeGr8NwQiZ46q7R3Rw-8I">
> ## Design input
> @kasiazjc I'm looking for a proposal where we consider the different chart 
> names length when calculating the spacing between charts.

Late to the party, sorry! 

But I am thinking - if chart name is longer than 2 lines we should truncate 
with "..." and show full name on hover. Two lines could also be a spacing that 
we use to keep everything consistent if that makes sense. Thoughts? 

GitHub link: 
https://github.com/apache/superset/discussions/32962#discussioncomment-12691723

----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: 
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to