geido commented on code in PR #32705:
URL: https://github.com/apache/superset/pull/32705#discussion_r2023002256
##########
superset-frontend/src/components/Input/index.tsx:
##########
@@ -17,10 +17,13 @@
* under the License.
*/
-import { Input as AntdInput, InputNumber as AntdInputNumber } from 'antd-v5';
-
-export const Input = AntdInput;
+import { Input as Antd5Input, InputNumber as AntdInputNumber } from 'antd-v5';
export const InputNumber = AntdInputNumber;
-export const { TextArea } = AntdInput;
+export const Input = Object.assign(Antd5Input, {
Review Comment:
I think this is unnecessary and we can safely remove it. It creates
additional maintenance on the component if we have to upgrade to a newer
version in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
