fhyy commented on PR #32857: URL: https://github.com/apache/superset/pull/32857#issuecomment-2757243513
@villebro test added. @mistercrunch this only fixes the issue for Drill as that's the engine I've been using and can verify. There are however another identical issue with Dremio #20349 which could be solved by a similar change. Other engines already have this suffix to avoid collisions, but I'm not sure if that was added to avoid this kind of problem. ([ClickHouse](https://github.com/apache/superset/blob/50fe7483ae3f7fa02a476b9e5e384bd0031359d7/superset/db_engine_specs/clickhouse.py#L416), [Databend](https://github.com/apache/superset/blob/50fe7483ae3f7fa02a476b9e5e384bd0031359d7/superset/db_engine_specs/databend.py#L366)) The problem with Drill in short is that it allows the use of aliases in GROUP BY statements, which breaks the queries Superset generates if the alias has the same name as the source column. See #28443 for more info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
