CharlesNkdl opened a new pull request, #32832: URL: https://github.com/apache/superset/pull/32832
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Fixes #32776 Added a subheader field type. Currently the subheader variable inherited from the big number viz props was unused so i added a field to handle it. Following this, the subheader and the compare lag (Comparaison Period Lag) couldn't be both handled in the front. So i took the liberty to let them co exist but the subheader might be used as a prefix, since there was already a suffix variable for the comparaison period lag. Both can be modified by subheader size ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Before :  After :    ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1 - Get a dataset 2 - Create a Big number with trendline 3 - Add a subheader ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [X] Has associated issue: https://github.com/apache/superset/issues/32776 - [ ] Required feature flags: - [X] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
