geido opened a new issue, #32823: URL: https://github.com/apache/superset/issues/32823
Please refer to SIP-139 https://github.com/apache/superset/issues/29268. The `src/components/IconButton` component should be removed and a standard `Card` component from Ant Design version 5 should be used instead. The component is currently on used in the Database modal.  The codebase is moving to Ant Design 5. Similar work has been completed [here](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed). When upgrading the component to Ant Design 5, please ensure to include: - Do not use unnecessary custom styles. We want to go as vanilla Ant Design as possible. - Proper RTL test coverage. - A Storybook file. - Include all relevant component options in the Storybook. When opening a PR: - Name your PR refactor({Component}): Refactor IconButton to use Ant Design 5 Card - Add screenshots of BEFORE/AFTER in your PR. - Make sure you or a committer has labeled your PR with [frontend:refactor:antd5](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
