CharlesNkdl opened a new pull request, #32739: URL: https://github.com/apache/superset/pull/32739
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Fixes #28551 Better handling of excel export, convert 10**15 numbers to a string to prevent truncation from xlsx format. Added test too ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable -->  Excel export : BEFORE : Big number 1 is truncated  AFTER : Big number 1 is a string but not truncated  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Create a dataset with some big numbers, such as : ``` SELECT NUMERIC '1100108628127863' AS big_number, NUMERIC '999999999999999' as big_number2 FROM video_game_sales ``` Try an excel export ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [X] Has associated issue: https://github.com/apache/superset/issues/28551 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
