korbit-ai[bot] commented on code in PR #32734:
URL: https://github.com/apache/superset/pull/32734#discussion_r2001943190
##########
superset-frontend/src/features/databases/UploadDataModel/index.tsx:
##########
@@ -539,6 +540,12 @@ const UploadDataModal:
FunctionComponent<UploadDataModalProps> = ({
}
}, [delimiter]);
+ useEffect(() => {
+ if (show) {
+ setActiveKey('general');
+ }
+ }, [show]);
Review Comment:
Good job on adding the documentation for the show effect. It would be more
helpful if there was more detail about what the show effect is and why
resetting activeKey is necessary when show changes. The name show effect is a
little ambiguous without additional context, so it could be useful to include
this in the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
