Vitor-Avila commented on PR #31331: URL: https://github.com/apache/superset/pull/31331#issuecomment-2733325503
Hey @MohamedHalat, Thank you so much for working on this! I just approved CI and everything is green now! 🙌 I would like to do some manual testing. Do you have any code snippets for manual testing? It might be good to add those to the embedded docs as well. At first, I thought the idea here would be to pass a method/callback to `getDataMasks` which would always be called when the dataMask changes in the dashboard, so I tried this: 1. Set `emitDataMasks` to `true` in the `dashboardUiConfig`. 2. Created a simple function that just prints the arguments received and passed this method to `getDataMasks` (I waited until `getScrollSize()` returned the dashboard `width` and `height` to make sure it's initiated). However, interacting with the dashboard (applying cross-filters/native filters) didn't call my method. Is the idea here the opposite? Like calling `getDataMasks()` the moment I want to know the current dashboard configuration? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
