zhutong6688 commented on code in PR #32556:
URL: https://github.com/apache/superset/pull/32556#discussion_r1986528860
##########
superset/databases/api.py:
##########
@@ -1055,15 +1057,21 @@ def table_metadata(self, pk: int) -> FlaskResponse:
parameters = QualifiedTableSchema().load(request.args)
except ValidationError as ex:
raise InvalidPayloadSchemaError(ex) from ex
-
- table = Table(parameters["name"], parameters["schema"],
parameters["catalog"])
+ table_name = str(parameters["name"])
+ table = Table(table_name, parameters["schema"], parameters["catalog"])
+ is_partitioned_table, partition_fields =
DatabaseDAO.is_odps_partitioned_table(
+ database, table_name
+ )
try:
security_manager.raise_for_access(database=database, table=table)
except SupersetSecurityException as ex:
# instead of raising 403, raise 404 to hide table existence
raise TableNotFoundException("No such table") from ex
-
- payload = database.db_engine_spec.get_table_metadata(database, table)
+ partition = Partition(is_partitioned_table, partition_fields)
+ if is_partitioned_table:
+ payload = OdpsEngineSpec.get_table_metadata(database, table,
partition)
+ else:
+ payload = database.db_engine_spec.get_table_metadata(database,
table)
Review Comment:
Because sqlglot has not yet implemented syntax parsing and compilation for
odps, the best approach at present is to check when retrieving metadata during
execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
