hainenber commented on code in PR #31979:
URL: https://github.com/apache/superset/pull/31979#discussion_r1932600860
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/utils.ts:
##########
@@ -35,10 +35,13 @@ const getFontSizeMapping = (
proportionValues: number[],
actualSizes: number[],
) =>
- proportionValues.reduce((acc, value, index) => {
- acc[value] = actualSizes[index] ?? actualSizes[actualSizes.length - 1];
- return acc;
- }, {});
+ proportionValues.reduce(
+ (acc, value, index) => {
+ acc[value] = actualSizes[index] ?? actualSizes[actualSizes.length - 1];
+ return acc;
+ },
+ {} as Record<number, number>,
+ );
Review Comment:
Thanks! Fixed in [this
commit](https://github.com/apache/superset/pull/31979/commits/4bf77d3f0236f1e4a4c6a8dea6523ba3e50982d0)
Edit: I fixed this one in the linked commit as well so apologies for not
commit your suggestion 🥲
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
