villebro commented on code in PR #31844:
URL: https://github.com/apache/superset/pull/31844#discussion_r1925766085
##########
superset/thumbnails/digest.py:
##########
@@ -92,11 +93,15 @@ def _adjust_string_with_rls(
def get_dashboard_digest(dashboard: Dashboard) -> str:
config = current_app.config
datasources = dashboard.datasources
- executor_type, executor = get_executor(
- executor_types=config["THUMBNAIL_EXECUTE_AS"],
- model=dashboard,
- current_user=get_current_user(),
- )
+ try:
+ executor_type, executor = get_executor(
+ executors=config["THUMBNAIL_EXECUTORS"],
+ model=dashboard,
+ current_user=get_current_user(),
+ )
+ except ExecutorNotFoundError:
+ return ""
Review Comment:
I agree. I've updated throughout the codebase (I did the same for
`thumbnail_url`, as that should really also be `None` if it's not defined).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
