michael-s-molina opened a new pull request, #31905:
URL: https://github.com/apache/superset/pull/31905

   ### SUMMARY
   When the `form_data_key` was created, it was used to share state between 
Superset users and required a secure key length. When permalinks were 
introduced, the `form_data_key` role changed to only be used for holding and 
transferring temporary state for a user session and not more for sharing state 
between Superset users. This PR reduces the `form_data_key` length given that 
an 8 bytes key is sufficient for its new role.
   
   As an example, this will be the diff:
   
   ```
   
form_data_key=yjxRBK8zEhgHTs2PhFKLpA3gja9yxkBRdVPP4xRtLFO2fipTttSpFjZEbizBbyhm
   
   form_data_key=z6OiPvci1q0
   ```
   
   ### TESTING INSTRUCTIONS
   CI should be sufficient.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to