betodealmeida commented on issue #31482:
URL: https://github.com/apache/superset/issues/31482#issuecomment-2596559771
A nit, but I wouldn't change the copy to say "Download CSV from S3", since
that's an implementation detail. All users care is that the file is downloaded.
What about making the CSV endpoint **always** return a 302 HTTP status code,
either to a Superset URL that would trigger the download or to a DB-specific
URL (S3 for Athena, eg). Then the config could look like this:
```python
DB_ENGINE_SPECS_CSV_DOWNLOAD = {
"athena": dict(
SUPERSET_REGION=eu-west-1,
SUPERSET_WORKGROUP=superset-etl,
SUPERSET_ATHENA_DB=my_superset_db,
),
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
