korbit-ai[bot] commented on code in PR #31894: URL: https://github.com/apache/superset/pull/31894#discussion_r1918954682
########## superset/config.py: ########## @@ -834,10 +834,11 @@ class D3TimeFormat(TypedDict, total=False): # Chrome allows up to 6 open connections per domain at a time. When there are more # than 6 slices in dashboard, a lot of time fetch requests are queued up and wait for -# next available socket. PR #5039 is trying to allow domain sharding for Superset, -# and this feature will be enabled by configuration only (by default Superset -# doesn't allow cross-domain request). -SUPERSET_WEBSERVER_DOMAINS = None +# next available socket. PR #5039 added domain sharding for Superset, +# and this feature can be enabled by configuration only (by default Superset +# doesn't allow cross-domain request). This feature is deprecated, annd will be removed +# in the next major version of Superset, as enabling HTTP2 will serve the same goals. +SUPERSET_WEBSERVER_DOMAINS = None # deprecated Review Comment: ### Include version for deprecation of 'SUPERSET_WEBSERVER_DOMAINS'. <sub></sub> <details> <summary>Tell me more</summary> ​ The comment describing the deprecation of 'SUPERSET_WEBSERVER_DOMAINS' should include the exact future version of Superset that will remove this feature, providing precise information to users. </details> ###### Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews. <!--- korbi internal id:7dd2e556-a2f5-4030-ad88-0aeb92aef3fa --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
