kgabryje commented on PR #25869: URL: https://github.com/apache/superset/pull/25869#issuecomment-2586857645
Hi @jansule! I noticed that this PR has added a huge chunk to the bundle (2.14MB parsed, visible in the top left corner in the first screenshot). For some reason it contains all antd icons (700kB) and pages/Chart module (500kB), which makes this chunk the largest one in the bundle. For comparison, second screenshot shows the bundle analysis after reverting this PR. It probably won't affect the loading times of the dashboards which don't contain the Cartodiagram chart, but we might want to solve this issue for the sake of loading performance of dashboards that use this plugin (especially for users with slower Internet) <img width="1728" alt="image" src="https://github.com/user-attachments/assets/0ee38055-6930-4484-9700-422686edbf5b"; /> <img width="1728" alt="image" src="https://github.com/user-attachments/assets/68e93eee-9e11-4a44-acd6-c1d6fa0b7e20"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
