dmytrohoi opened a new pull request, #31792:
URL: https://github.com/apache/superset/pull/31792
### SUMMARY
Fixes #25592
Added clearing of popoverLabel and hasCustomLabel states. Merged handlers
that works with toggle/close from props and locally implemented in component to
work with new column selectors and edit existing ones.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TBD
### TESTING INSTRUCTIONS
1. On the chart table agregattion edit page
2. Add new column with custom title
3. Open new popover to add column
4. Check that column name in popover is default ('My Column')
### ADDITIONAL INFORMATION
- [x] Has associated issue: #25592
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
