kasiazjc commented on PR #31575: URL: https://github.com/apache/superset/pull/31575#issuecomment-2580121114
@mistercrunch yay, was able to test in the test env! 🎉 Two things from me: - I would keep green, yellow and red for success, warning, error (as they are pretty intuitive) and for other things that need a label use different colors/shades. So I would suggest changing Virtual to for example secondary color. - found one thing to fix: in database list virtual doesn't have a hover state, and physical has - it doesn't have an action, so I guess we need to get rid of hover https://github.com/user-attachments/assets/a8eb675a-a29d-4720-95d6-e00977f65240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
