villebro commented on code in PR #31503:
URL: https://github.com/apache/superset/pull/31503#discussion_r1905805671
##########
.github/actions/setup-backend/action.yml:
##########
@@ -26,11 +26,12 @@ runs:
shell: bash
run: |
if [ "${{ inputs.python-version }}" = "current" ]; then
- echo "PYTHON_VERSION=3.10" >> $GITHUB_ENV
+ echo "PYTHON_VERSION=3.11.11" >> $GITHUB_ENV
elif [ "${{ inputs.python-version }}" = "next" ]; then
+ # TODO: set to 3.12 when libs are ready - seemed hard on 12/17/24
echo "PYTHON_VERSION=3.11" >> $GITHUB_ENV
Review Comment:
Aren't these reversed, i.e. `current` should point to `3.11` and `next`
should point to `3.11.11`?
##########
pyproject.toml:
##########
@@ -24,15 +24,15 @@ name = "apache-superset"
description = "A modern, enterprise-ready business intelligence web
application"
readme = "README.md"
dynamic = ["version", "scripts", "entry-points"]
-requires-python = ">=3.9"
+requires-python = ">=3.10"
license = { file="LICENSE.txt" }
authors = [
{ name = "Apache Software Foundation", email = "[email protected]"
},
]
classifiers = [
- "Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
+ # "Programming Language :: Python :: 3.12", # not just yet ...
Review Comment:
If 3.12 isn't supported yet, I'd just remove this for now.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
