geido commented on code in PR #31019:
URL: https://github.com/apache/superset/pull/31019#discussion_r1898447562
##########
superset-frontend/packages/superset-ui-chart-controls/src/constants.ts:
##########
@@ -82,4 +82,4 @@ export const DEFAULT_XAXIS_SORT_SERIES_DATA: SortSeriesData =
{
export const DEFAULT_DATE_PATTERN = /\d{4}-\d{2}-\d{2}/g;
// When moment fails to parse a date
Review Comment:
```suggestion
// When it fails to parse a date
```
##########
superset-frontend/src/utils/dates.ts:
##########
@@ -16,6 +16,18 @@
* specific language governing permissions and limitations
* under the License.
*/
+
+import 'dayjs/locale/de';
+import 'dayjs/locale/es';
+import 'dayjs/locale/fr';
+import 'dayjs/locale/it';
+import 'dayjs/locale/ja';
+import 'dayjs/locale/ko';
+import 'dayjs/locale/pt';
+import 'dayjs/locale/pt-br';
+import 'dayjs/locale/ru';
+import 'dayjs/locale/zh';
Review Comment:
This is a bit of a problem because now we are making localization dependent
on this file. Is there a better way to achieve this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
