korbit-ai[bot] commented on code in PR #31606: URL: https://github.com/apache/superset/pull/31606#discussion_r1896028041
########## docker/docker-bootstrap.sh: ########## @@ -18,13 +18,12 @@ set -eo pipefail -# UV may not be installed in older images -pip install uv - # Make python interactive if [ "$DEV_MODE" == "true" ]; then - echo "Reinstalling the app in editable mode" - uv pip install -e . + if command -v uv > /dev/null 2>&1; then + echo "Reinstalling the app in editable mode" + uv pip install -e . + fi fi Review Comment: ### Missing pip fallback in DEV_MODE <sub></sub> <details> <summary>Tell me more</summary> ###### What is the issue? When UV is not available in DEV_MODE, the script silently skips the installation without falling back to regular pip or warning the user. ###### Why this matters This could lead to missing dependencies in development environments where UV is not available, potentially causing runtime issues. ###### Suggested change Add pip fallback: if [ "$DEV_MODE" == "true" ]; then echo "Reinstalling the app in editable mode" if command -v uv > /dev/null 2>&1; then uv pip install -e . else pip install -e . fi fi </details> ###### Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews. <!--- korbi internal id:9a66e740-7f25-4bfa-8818-ae2b2d4a8ae0 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
