mistercrunch opened a new pull request, #31588:
URL: https://github.com/apache/superset/pull/31588

   closes https://github.com/apache/superset/issues/31510
   
   When using docker-compose-non-dev.yml or docker-compose.yml, we mount the 
`docker/` directory in the container. This means we use the logic in the 
docker-related scripts from whatever branch the user has checked out locally 
into the container, and. Since `uv` was introduced recently, older images don't 
have it, and the script fail.
   
   Here to unblock I'm adding `pip install uv` to the bootstrap script, which 
should enable things to run.
   
   Moving forward, it'd be better if docker-compose would NOT mount the 
`docker/` directory, and instead use the `docker/` directory from the image. 
This would ensure that the scripts are always in sync with the image. This is a 
bit more involved, so I'm going with the simpler fix for now. This also 
requires having the right entrypoints / CMD instruciton set IN the image. 
Unclear how whether it's setup ok in older releases, would require pulling each 
release branch and looking into the entrypoints/CMD instructions in their 
respective Dockerfiles.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to