ERGO1995 commented on PR #31498: URL: https://github.com/apache/superset/pull/31498#issuecomment-2549301653
> I'm curious more about the use cases here... > > Should this perhaps be user-controllable (there's a switch for it in SQL Lab results, for example), rather than a feature flag? I'm not sure if we want to _always_ enable or disable this for everyone. > > If we DO need a feature flag, perhaps we should have a more generic "RENDER_HTML_IN_DATA" flag, that can be used for any tables (pivot or otherwise) or results displays? Hey, when I checked the code for the "Table" and "Pivot Table" charts, I noticed that the variable is set to true by default only on the "Table" side. If there is a good reason for this, I assume we wouldn't want just any regular user to make a change to allow it. Based on this assumption, I used feature flags so that someone with proper expertise can set this feature flag to True. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
