Vitor-Avila opened a new pull request, #31437: URL: https://github.com/apache/superset/pull/31437
### SUMMARY As part of the DB import logic, Superset creates all permissions for the connection (`database access on ...`, `catalog access on ...`, `schema access on ...`, etc). It's possible that the credentials used for the connection has access to list all catalogs, but can't get the schemas for every catalog (this is reproducible if you create an AWS RDS PSQL - the master account will list the `rdsadmin` DB but can't list its schemas). There was already logic in place to gracefully handle this scenario in the DB creation method. This PR implements the following changes: 1. Moves the `add_permissions` helper that was being used in `superset/commands/database/importers/v1/utils.py` to `superset/commands/database/utils.py` (since now it's used both by import and create commands). 2. Includes the `try/except` logic that was already present in the create command to the `add_permissions` helper. 3. Update both commands to use this helper, so that it's DRYer. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI changes. Import should work without errors. ### TESTING INSTRUCTIONS Unit test added. For manual testing: 1. Connect to an AWS RDS PSQL DB. 2. Export the connection. 3. Validate that importing it works. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
