nsivarajan commented on code in PR #31173:
URL: https://github.com/apache/superset/pull/31173#discussion_r1871608810
##########
superset/tasks/utils.py:
##########
@@ -133,7 +133,7 @@ def fetch_csrf_token(
data = json.loads(body)
res = {"X-CSRF-Token": data["result"]}
if session_cookie is not None:
- res["Cookie"] = session_cookie
+ res["Cookie"] = f"{session_cookie_name}={session_cookie}"
Review Comment:
Thank you for the feedback and guidance. I believe this change should not
break anything, as it correctly identifies the session cookie and forwards it
for further user validation in `ChartRestApi.warm_up_cache`. To ensure
robustness, I have also conducted additional tests to confirm that it behaves
as expected across all relevant use cases, including HTTP, HTTPS, reverse proxy
redirection, and scenarios with WS/polling enabled or disabled for asynchronous
operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
