michael-s-molina commented on code in PR #31187:
URL: https://github.com/apache/superset/pull/31187#discussion_r1862219194
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -342,7 +346,21 @@ const ResultSet = ({
buttonSize="small"
href={getExportCsvUrl(query.id)}
data-test="export-csv-button"
- onClick={() => logAction(LOG_ACTIONS_SQLLAB_DOWNLOAD_CSV, {})}
+ onClick={() => {
+ logAction(LOG_ACTIONS_SQLLAB_DOWNLOAD_CSV, {});
+ if (
+ limitingFactor === LimitingFactor.Dropdown &&
+ limit === rowsCount
+ ) {
+ Modal.warning({
+ title: t('Download is on the way'),
+ content: t(
+ 'Downloading %(rows)s rows based on LIMIT setting! If
you want the entire result set, change the LIMIT settings.',
Review Comment:
```suggestion
'Downloading %(rows)s rows based on the LIMIT
configuration. If you want the entire result set, you need to adjust the
LIMIT.',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
