Antonio-RiveroMartnez commented on code in PR #31163:
URL: https://github.com/apache/superset/pull/31163#discussion_r1858957679


##########
superset-frontend/src/utils/colorScheme.ts:
##########
@@ -31,6 +31,10 @@ import {
  */
 export const getColorNamespace = (namespace?: string) => namespace || 
undefined;
 
+export const ensureSharedLabelsColorsArray = (

Review Comment:
   Probably because of the other "ensure" methods that transform  to a given 
type (Array for example), but this method seems to instead being doing a 
different thing with dicts by returning [], so we might want to consider a 
different name for it? or return a list with the dict values instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to