villebro commented on code in PR #30987:
URL: https://github.com/apache/superset/pull/30987#discussion_r1855152930
##########
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/types.ts:
##########
@@ -52,6 +52,10 @@ export const DEFAULT_FORM_DATA:
Partial<EchartsSunburstFormData> = {
labelType: EchartsSunburstLabelType.Key,
showLabels: false,
dateFormat: 'smart_date',
+ innerRadius: 30,
+ outerRadius: 70,
+ donut: true,
+ showNulls: true,
Review Comment:
This will change how all current sunburst charts are rendered. While I'm not
strongly against/for this, I'm not sure we want to forcefully change all
current charts. For this reason I would recommend changing the defaults to
align with the current behavior, and defer changing the defaults to a later
date when there's been a decision to to change the defaults. Maybe we could
discuss changing the defaults for the pie chart and sunburst chart in a
forthcoming town hall? CC @rusackas @michael-s-molina
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
