kgabryje commented on PR #30958:
URL: https://github.com/apache/superset/pull/30958#issuecomment-2486707449
Neat AI summary provided by @rusackas 🙂
Key changes include:
1. Memoization optimizations:
- Added useMemo/useCallback hooks throughout components
- Memoized selectors with createSelector
- Reduced unnecessary re-renders
2. Component modernization:
- Converted class components to functional components with hooks
- Removed redundant Redux connections in favor of useSelector/useDispatch
- Simplified prop passing and state management
3. Architecture improvements:
- Moved Chart container logic directly into component
- Simplified data flow and prop drilling
- Better separation of concerns
The main potential risk areas to watch:
1. FilterBar and native filtering changes - ensure filter state management
remains consistent with previous behavior
2. Chart component refactoring - verify chart rendering and updates work
correctly, especially around:
- Data loading states
- Filter interactions
- Resize handling
3. Tab/Dashboard navigation - confirm tab state management and routing
remains intact
Recommend thorough testing of:
- Filter interactions
- Chart loading/rendering
- Dashboard navigation
- Cross-filter functionality
- Dashboard state persistence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
