theoriginalgri opened a new pull request, #30966: URL: https://github.com/apache/superset/pull/30966
### SUMMARY https://github.com/apache/superset/pull/30710 introduced extraLabels but broke the PodDisruptionBudgets due to pdb configs using "with" statements. This is not catched by the linting since since checks are only performed with default values and PDBs are not enabled by default. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: ``` $ helm lint ./helm/superset --set "supersetNode.podDisruptionBudget.enabled=true" engine.go:227: [INFO] Fail: Only one of minAvailable or maxUnavailable should be set ==> Linting ./helm/superset [ERROR] templates/: template: superset/templates/pdb.yaml:34:18: executing "superset/templates/pdb.yaml" at <.Values.extraLabels>: nil pointer evaluating interface {}.extraLabels Error: 1 chart(s) linted, 1 chart(s) failed ``` After: ``` $ helm lint ./helm/superset --set "supersetNode.podDisruptionBudget.enabled=true" engine.go:227: [INFO] Fail: Only one of minAvailable or maxUnavailable should be set ==> Linting ./helm/superset 1 chart(s) linted, 0 chart(s) failed ``` ### TESTING INSTRUCTIONS ```shell helm lint ./helm/superset --set "supersetNode.podDisruptionBudget.enabled=true" ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
