mistercrunch commented on issue #30916: URL: https://github.com/apache/superset/issues/30916#issuecomment-2479750933
I think we wanted to add `scripts/check-env.py` in some contexts so that we can catch this earlier in the build cycle and provide clear error messages (instead of processes just vanishing as they do when they get killed by the OS), but at the same time I don't want to make the current CI flows more complicated where we do have 16GB. I thought about adding it to the docker-compose workflow but it's difficult since docker-compose runs a `build` prior to doing anything else, which points to running this inside the Dockerfile which isn't super elegant. Other option is to wrap `docker-compose` into some shell script that runs the check first. My favorite solution is probably to improve the docs to reference `check-env.py` as a step prior to building, maybe mentioning the system requirements / assumptions for Superset too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
