villebro opened a new pull request, #30926:
URL: https://github.com/apache/superset/pull/30926

   ### SUMMARY
   The `PrestoBaseEngineSpec` that's used by the Presto and Trino specs is 
missing some intermediate second, minute and hour time grains. This adds those 
+ unit tests on the actual spec implementations to protect against regressions.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   A Trino chart using the new 5 minute time grain:
   <img width="710" alt="image" 
src="https://github.com/user-attachments/assets/7fe8c69b-0301-483d-bc1e-0f8ce553f412";>
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to