villebro commented on code in PR #30897:
URL: https://github.com/apache/superset/pull/30897#discussion_r1837311547
##########
superset/views/sql_lab/views.py:
##########
@@ -169,102 +182,118 @@ def put(self, tab_state_id: int) -> FlaskResponse:
if owner_id != get_user_id():
return Response(status=403)
- fields = {k: json.loads(v) for k, v in request.form.to_dict().items()}
- if client_id := fields.get("latest_query_id"):
- query =
db.session.query(Query).filter_by(client_id=client_id).one_or_none()
- if not query:
- return self.json_response({"error": "Bad request"}, status=400)
Review Comment:
I don't fully grasp why this was here in the first place (it would probably
have been a good idea to add a comment here if this was in fact needed), but do
you have any idea why
- this was here?
- it can be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
