fmannhardt commented on PR #30438: URL: https://github.com/apache/superset/pull/30438#issuecomment-2429705988
Thanks. Just to confirm it does break our use case in 4.1rc3 for two underlying reasons: (1) The column filtering is renamed with a label (colx as X). So, cross filtering does consider it as X. (2) We used JINJA to create a custom filter condition based on selected filters (on X) but since there there is no column X in the dataset, it won't do the filtering on the chart. Btw, it does filter correctly when clicking on show the data as table or as SQL statement. So, the filtering is inconsistent. I think the code checking for expressions (quoted above) simply does not check there WHERE filters defined on the charts. It may also have issues with custom charts. ________________________________ From: Geido ***@***.***> Sent: Tuesday, October 22, 2024 2:57:19 PM To: apache/superset ***@***.***> Cc: Felix ***@***.***>; Mention ***@***.***> Subject: Re: [apache/superset] fix(Filters): Apply native & cross filters on common columns (PR #30438) Thanks @Mainer-g00t<https://github.com/Mainer-g00t> and @fmannhardt<https://github.com/fmannhardt>. Let me have a deeper look at what you are mentioning. — Reply to this email directly, view it on GitHub<https://github.com/apache/superset/pull/30438#issuecomment-2429214429>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAYN7NVWRPCG2GXD4CF4KJDZ4ZDS7AVCNFSM6AAAAABPDK75DSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZGIYTINBSHE>. You are receiving this because you were mentioned.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
