villebro commented on code in PR #30425:
URL: https://github.com/apache/superset/pull/30425#discussion_r1792543858
##########
superset/commands/dashboard/export.py:
##########
@@ -190,6 +201,5 @@ def _export(
if dataset_id is not None:
dataset = DatasetDAO.find_by_id(dataset_id)
if dataset:
- target["datasetUuid"] = str(dataset.uuid)
Review Comment:
At the risk of introducing yet more regressions, I feel it would be cleaner
to do the following:
```python
if export_related:
for target in native_filter...
```
The point being, no sense in iterating over all datasets, if
`export_related` is `False`, as we're not doing anything else here (look at how
charts are exported above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
