sadpandajoe commented on code in PR #30395:
URL: https://github.com/apache/superset/pull/30395#discussion_r1776143183
##########
superset-frontend/cypress-base/cypress/e2e/explore/chart.test.js:
##########
@@ -122,32 +122,32 @@ describe('Cross-referenced dashboards', () => {
});
});
-describe('No Results', () => {
- beforeEach(() => {
- cy.intercept('POST', '/superset/explore_json/**').as('getJson');
- });
-
- it('No results message shows up', () => {
- const formData = {
- ...FORM_DATA_DEFAULTS,
- metrics: [NUM_METRIC],
- viz_type: 'line',
- adhoc_filters: [
- {
- expressionType: 'SIMPLE',
- subject: 'state',
- operator: 'IN',
- comparator: ['Fake State'],
- clause: 'WHERE',
- sqlExpression: null,
- },
- ],
- };
-
- cy.visitChartByParams(formData);
- cy.wait('@getJson').its('response.statusCode').should('eq', 200);
- cy.get('div.chart-container').contains(
- 'No results were returned for this query',
- );
- });
-});
+// describe('No Results', () => {
Review Comment:
you can do a describe.skip here to skip all these tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
