kgabryje opened a new pull request, #30348:
URL: https://github.com/apache/superset/pull/30348

   ### SUMMARY
   Recent Echarts bundle size optimization PR didn't register 
`MarkLineComponent` and `MarkAreaComponent` from `echarts/components` package, 
which broke annotations.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   <img width="1728" alt="image" 
src="https://github.com/user-attachments/assets/1015f78c-9ea8-4bf4-baeb-2351785e958d";>
   
   After:
   
   <img width="1728" alt="image" 
src="https://github.com/user-attachments/assets/33f735d8-3fbd-428e-beb0-b611507c0005";>
   
   
   ### TESTING INSTRUCTIONS
   1. Create an annotation layer 
       * date 2000-01-20 15:50 -> 2000-03-01 15:50
   2. Save
   3. Go to the `Country Growth Rate` chart
   4. Add the annotation 
       * Show labe = checked
       * annotation layer type = interval
       * annotation source = Superset annotation 
       * annotation layer = your annotation layer
       * hit ok
   5. click update chart
   6. Verify that the annotation is visible
   7. Do the same for annotation layer type = Event
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to