nyohasstium opened a new pull request, #30318: URL: https://github.com/apache/superset/pull/30318
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> fix(embedded dashboard): resource type was not checked appropriately against enum. feat(UI): added currency and language to URL_PARAMS feat(API): using language based on query parameter if found and defaulting to session value ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - Embed a dashboard using the superset-embedded-sdk package. - Set lang and currency in the urlParams options. - Depending on the chosen language, the ui will be rendered with it. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [X] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [X] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
