kgabryje opened a new pull request, #30176: URL: https://github.com/apache/superset/pull/30176
### SUMMARY Cross filtering feature is designed to apply filters based on a dimension that user clicked in the source chart. In some chart plugins, when the chart has no dimensions (only metric series), click on a metric would emit an empty cross filter, providing confusing user experience. This PR disables cross filtering on charts that have no dimensions set. Additionally, some charts were marked as compatible with cross filtering feature (`behaviors: [Behavior.InteractiveChart]`), but were in fact not implementing the feature. In those charts I removed the behavior and added a `TODO` comment to implement cross filtering. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS 1. Go to "Featured Charts" dashboard. 2. Verify that charts with dimensions (e.g. Area, Box Plot, Gauge, Pie) still emit cross filters as before 3. Verify that charts with no dimensions (e.g. Mixed) do not emit cross filters - nothing happens on click, cross filtering option in context menu is disabled 4. Add more charts with no dimensions to the dashboard, verify that they don't emit cross filters after clicking on a metric series. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/30056 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
