mistercrunch commented on code in PR #28628:
URL: https://github.com/apache/superset/pull/28628#discussion_r1746360190
##########
superset/config.py:
##########
@@ -196,6 +196,13 @@ def _try_json_readsha(filepath: str, length: int) -> str |
None:
# SQLALCHEMY_DATABASE_URI = 'mysql://myapp@localhost/myapp'
# SQLALCHEMY_DATABASE_URI = 'postgresql://root:password@localhost/myapp'
+# The default MySQL isolation level is REPEATABLE READ whereas the default
PostgreSQL
+# isolation level is READ COMMITTED. All backends should use READ COMMITTED
(or similar)
+# to help ensure consistent behavior.
+SQLALCHEMY_ENGINE_OPTIONS = {
+ "isolation_level": "SERIALIZABLE", # SQLite does not support READ
COMMITTED.
Review Comment:
@sadpandajoe followed the rabbit hole here, and I think you're right, this
will bump all envs who don't set their SQLALCHEMY_ENGINE_OPTIONS to a higher
isolation level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
