rtexelm commented on code in PR #30027:
URL: https://github.com/apache/superset/pull/30027#discussion_r1736376719
##########
superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/index.tsx:
##########
@@ -161,7 +65,7 @@ const DatabaseConnectionForm = ({
Object.keys(parameters.properties).includes(key) ||
key === 'database_name',
).map(field =>
- FORM_FIELD_MAP[field]({
+ (FORM_FIELD_MAP as any)[field]({
Review Comment:
This was just a quick-fix from copilot for a `ts` error that is negligible
in the scope of this PR and a house of cards for typing incompatibility
throughout the database modal so i'm going to revert it for now and maybe the
type definitions can be revised in a later PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
