sfirke commented on code in PR #30030: URL: https://github.com/apache/superset/pull/30030#discussion_r1734835674
########## UPDATING.md: ########## @@ -32,9 +32,9 @@ assists people when migrating to a new version. `requirements/` folder. If you use these files for your builds you may want to double check that your builds are not affected. `base.txt` should be the same as before, though `development.txt` becomes a bigger set, incorporating the now defunct local,testing,integration, and docker -- [27434](https://github.com/apache/superset/pull/27434/files): DO NOT USE our docker-compose.\* Review Comment: When talking about the files, they don't have spaces in the filenames so `docker-compose` is still correct IMO ########## docs/docs/installation/docker-compose.mdx: ########## @@ -44,9 +44,9 @@ More on these two approaches after setting up the requirements for either. ## Requirements -Note that this documentation assumes that you have [Docker](https://www.docker.com), -[docker-compose](https://docs.docker.com/compose/), and -[git](https://git-scm.com/) installed. +Note that this documentation assumes that you have [Docker](https://www.docker.com) and +[git](https://git-scm.com/) installed. Note also that we used to use `docker-compose` but that Review Comment: ```suggestion [git](https://git-scm.com/) installed. Superset has switched from using the deprecated `docker-compose` to `docker compose`. ``` ########## docs/docs/installation/docker-compose.mdx: ########## @@ -13,9 +13,9 @@ import useBaseUrl from "@docusaurus/useBaseUrl"; <br /><br /> :::caution -Since `docker-compose` is primarily designed to run a set of containers on **a single host** +Since `docker compose` is primarily designed to run a set of containers on **a single host** and can't support requirements for **high availability**, we do not support nor recommend -using our `docker-compose` constructs to support production-type use-cases. For single host +using our `docker- ompose` constructs to support production-type use-cases. For single host Review Comment: You deleted the wrong character 😆 ########## docs/docs/quickstart.mdx: ########## @@ -40,6 +40,7 @@ container images and will load up some examples. Once all containers are downloaded and the output settles, you're ready to log in. ⚠️ If you get an error message like `validating superset\docker-compose-image-tag.yml: services.superset-worker-beat.env_file.0 must be a string`, you need to update your version of `docker-compose`. +Note that `docker-compose` is on the path to deprecation and you should now use `docker compose` instead. Review Comment: I think instead of adding this line, you could just replace `docker-compose` in the preceding line with `docker compose` ########## docs/docs/installation/docker-compose.mdx: ########## @@ -44,9 +44,9 @@ More on these two approaches after setting up the requirements for either. ## Requirements -Note that this documentation assumes that you have [Docker](https://www.docker.com), -[docker-compose](https://docs.docker.com/compose/), and -[git](https://git-scm.com/) installed. +Note that this documentation assumes that you have [Docker](https://www.docker.com) and +[git](https://git-scm.com/) installed. Note also that we used to use `docker-compose` but that +is on the path to deprecation so we now use `docker compose` instead. Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
