michael-s-molina commented on code in PR #30029:
URL: https://github.com/apache/superset/pull/30029#discussion_r1733326159
##########
tests/integration_tests/migrations/f84fde59123a_update_charts_with_old_time_comparison__test.py:
##########
@@ -161,6 +161,70 @@
}
],
}
+params_v1_other_than_custom_false: dict[str, Any] = {
Review Comment:
Would you mind extracting the common parts between `params_v1_with_custom`,
`params_v1_other_than_custom_false`, `params_v2_with_custom`,
`params_v2_other_than_custom`, `params_v2_other_than_custom_false` and just
override the necessary properties for each variable to avoid code duplication
and increase readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
