mistercrunch commented on issue #29839: URL: https://github.com/apache/superset/issues/29839#issuecomment-2274344041
> "proper" task cancellation I'm guessing it's about running a certain routine when that happens. Some databases don't cancel the query on client disconnections, and would require us to run a routine of to kill the query. Something as simple as the STOP button in SQL Lab would have to hit an endpoint that would `celery.revoke(task_id, terminate=True)`, and rely on some except Conversing with GPT it seems there are ways to configure and catch things: <img width="832" alt="Screenshot 2024-08-07 at 1 59 44 PM" src="https://github.com/user-attachments/assets/f4f0a8fe-6290-4fee-a608-43274facd61b";> In my experience (mostly around Airflow's CeleryExecutor) it's common to end up with things not firing as expected, zombie tasks (Superset think the job is dead but still running somewhere on a worker machine), undead task (Superset the job is running, but nothing is running), forcing us to double-check the state. Seems like the framework is built for fire-and-forget typical web-scale workloads, as opposed to long-running tasks with good support for cancelation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
