mistercrunch commented on code in PR #29864:
URL: https://github.com/apache/superset/pull/29864#discussion_r1704597643
##########
.github/workflows/pre-commit.yml:
##########
@@ -16,6 +16,9 @@ concurrency:
jobs:
pre-commit:
runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ python-version: ["current", "next", "previous"]
Review Comment:
It's like this for very good reason - has to do with
`required_status_checks` and matrix-management. There's all sorts of issues
around renaming checks/matrix members and required checks. When we'll bump
python version we'll be able to do it centrally in
`.github/actions/setup-backend/action.yml` (current/next/future is defined by
us in there), and we won't have issues around having to rename check names in
master prior to being able to merge the branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
