sfirke commented on PR #24835: URL: https://github.com/apache/superset/pull/24835#issuecomment-2269159073
Hi @doctorseus, sorry this lingered so long. Upon looking at it now it seems like a good improvement to me, with the justification that this DB variable is like the SECRET_KEY in that it is so frequently something that one wants to change upon startup and this makes it slightly easier for some people. Your use of `or` looks good to me. Unfortunately this now has a conflict. But it should be easy to reconcile. If you are up for updating your fork, then reapplying your change on top of currently master, I will approve + merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
