justinpark commented on code in PR #29395:
URL: https://github.com/apache/superset/pull/29395#discussion_r1703959090
##########
superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx:
##########
@@ -108,6 +110,38 @@ const StyledTabsContainer = styled.div`
}
`;
+const StyledCancelXIcon = styled(Icons.CancelX)`
+ color: ${({ theme }) => theme.colors.grayscale.base};
+`;
+
+const RightDropIndicator = styled.div`
+ border: 2px solid ${({ theme }) => theme.colors.primary.base};
+ width: 5px;
+ height: 100%;
+ position: absolute;
+ top: 0;
+ right: -4px;
+ border-radius: 2px;
+`;
+const LeftDropIndicator = styled.div`
Review Comment:
The two Indicator components appear to be identical.
If so, how about doing it this way?
```suggestion
const DropIndicator = styled.div<{ pos: 'left' | 'right' }>`
border: 2px solid ${({ theme }) => theme.colors.primary.base};
width: 5px;
height: 100%;
position: absolute;
top: 0;
${({ pos }) => pos === 'left' ? 'left: -4px' : 'right: -4px' };
border-radius: 2px;
`;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
