mistercrunch commented on PR #29798: URL: https://github.com/apache/superset/pull/29798#issuecomment-2261277953
> he alert / reporting run would not occur at the configured time and timezone and instead occur at time offset by the configured timezone's Makes sense, though wondering its possible that people might have set their alerts/reports while relying on this quirky behavior. Can we clarify the scope of alerts that would be affected (say "only the ones that set a TZ")? Is this an edge case or does it affect most alerts out there? We have to think of the thousands of organizations running hundreds of thousands or alerts/reports every day... If it's a small portion of alerts/reports, maybe a note in UPDATING.md is sufficiant. If it's a a large portion of alerts/reports, we have different options - a db migration that makes sure that effective run time of alerts are not affected, altering the existing alerts - wait for the next major release to ship as a breaking change - some sort of flag for each alert (new_scheduling_logic = True/False) where we apply the old/new logic conditionally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
