geido commented on code in PR #29666:
URL: https://github.com/apache/superset/pull/29666#discussion_r1697201713
##########
superset-frontend/src/theme/index.ts:
##########
@@ -64,6 +64,11 @@ const baseConfig: ThemeConfig = {
borderRadiusSM: supersetTheme.gridUnit / 2,
defaultBg: supersetTheme.colors.grayscale.light4,
},
+ Progress: {
+ fontSize: supersetTheme.typography.sizes.s,
Review Comment:
This was a decision we made to keep the style centralized rather than
scattered across. The component tokens are relevant to general theme, as the
general theme might need to be tweaked if we realize that multiple components
are using the same styles and thus should be promoted. We can reconsider this
choice once the big part of the transition is done and the general theme should
be stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
