michael-s-molina commented on code in PR #29776: URL: https://github.com/apache/superset/pull/29776#discussion_r1696991026
########## superset/commands/dashboard/copy.py: ########## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import logging +from functools import partial +from typing import Any + +from superset import is_feature_enabled, security_manager +from superset.commands.base import BaseCommand +from superset.commands.dashboard.exceptions import ( + DashboardForbiddenError, + DashboardInvalidError, +) +from superset.daos.dashboard import DashboardDAO +from superset.models.dashboard import Dashboard +from superset.utils.decorators import on_error, transaction + +logger = logging.getLogger(__name__) + + +class CopyDashboardCommand(BaseCommand): + def __init__(self, original_dash: Dashboard, data: dict[str, Any]) -> None: + self._original_dash = original_dash + self._properties = data.copy() + + @transaction(on_error=partial(on_error, reraise=DashboardInvalidError)) Review Comment: Could you reraise using a more generic exception such as `DashbordCopyError` (will need to create)? `reraise` means catching all exceptions and re-raising them as a generic one. For example, you might have `DashboardForbiddenError` which would be weird to be thrown as `DashboardInvalidError`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
